Skip to content

Translate "DEV link to blog page" #2163 (ko) #2354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 16, 2020
Merged

Conversation

riseshia
Copy link
Member

@riseshia riseshia commented Jan 16, 2020

Master issue: #1894
Translated PR: #2163

Actual diff is ca88db4
Could you review this?

@riseshia riseshia requested a review from a team January 16, 2020 06:55
@riseshia
Copy link
Member Author

Thanks~

@riseshia riseshia merged commit 0bd8987 into ruby:master Jan 16, 2020
@riseshia riseshia deleted the ruby-tag branch January 16, 2020 08:50
@stomar
Copy link
Contributor

stomar commented Jan 20, 2020

When squashing commits, please fix the commit messages in a meaningful way; the default of listing all individual commit messages of intermediate small steps like below often doesn't make sense in the final history, but only adds noise (the summary in the first line would have been enough).

Translate "DEV link to blog page" #2163 (ko) (#2354)

* backport "DEV link to blog page" #2354
* Translate text

@riseshia
Copy link
Member Author

I will be more careful..! Thanks for the comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants